Skip to content

Add pubsub subscriber leaser#5210

Merged
theacodes merged 2 commits into
googleapis:masterfrom
theacodes:pubsub-subscriber-leaser
Apr 19, 2018
Merged

Add pubsub subscriber leaser#5210
theacodes merged 2 commits into
googleapis:masterfrom
theacodes:pubsub-subscriber-leaser

Conversation

@theacodes
Copy link
Copy Markdown
Contributor

@theacodes theacodes commented Apr 18, 2018

This is another helper thread that maintains the leases for any messages that the current subscriber is working on. The majority of this code (notably, maintain_leases) is copied from pubsub_v1.subscriber.policy.base.BasePolicy.maintain_leases.

Add pubsub subscriber leaser
ad3b59c 
This is another helper thread that maintains the leases for any messages that the current subscriber is working on. The majority of this code (notably, `maintain_leases`) is copied from `pubsub_v1.subscriber.policy.base.BasePolicy.maintain_leases`.
@theacodes theacodes requested a review from crwilcox April 18, 2018 22:13
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 18, 2018
crwilcox
crwilcox suggested changes Apr 18, 2018
View reviewed changes
Comment thread pubsub/google/cloud/pubsub_v1/subscriber/_protocol/leaser.py Outdated
self._subscriber.drop(to_drop)

# Remove dropped items from our copy of the leased messages (they
# have already been removed from the real one by self.drop).

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread pubsub/google/cloud/pubsub_v1/subscriber/_protocol/leaser.py

# Remove dropped items from our copy of the leased messages (they
# have already been removed from the real one by self.drop).
for item in to_drop:

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread pubsub/google/cloud/pubsub_v1/subscriber/_protocol/leaser.py Outdated
# Create a streaming pull request.
# We do not actually call `modify_ack_deadline` over and over
# because it is more efficient to make a single request.
ack_ids = list(leased_messages.keys())

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread pubsub/google/cloud/pubsub_v1/subscriber/_protocol/leaser.py
# period between 0 seconds and 90% of the lease. This use of
# jitter (http://bit.ly/2s2ekL7) helps decrease contention in cases
# where there are many clients.
snooze = random.uniform(0.0, p99 * 0.9)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread pubsub/tests/unit/pubsub_v1/subscriber/test_leaser.py
leaser_ = leaser.Leaser(mock.sentinel.subscriber)

leaser_.add([
requests.LeaseRequest(ack_id='ack1', byte_size=50)])

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@theacodes theacodes merged commit 00e618a into googleapis:master Apr 19, 2018
@theacodes theacodes deleted the pubsub-subscriber-leaser branch April 19, 2018 21:22
parthea pushed a commit that referenced this pull request Mar 2, 2026
Add pubsub subscriber leaser (#5210)
0cf69ff 
This is another helper thread that maintains the leases for any messages that the current subscriber is working on. The majority of this code (notably, `maintain_leases`) is copied from `pubsub_v1.subscriber.policy.base.BasePolicy.maintain_leases`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

1 more reviewer

@crwilcox crwilcox crwilcox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@theacodes @crwilcox @googlebot